Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist devDeps with Lerna #4442

Closed
wants to merge 2 commits into from
Closed

Hoist devDeps with Lerna #4442

wants to merge 2 commits into from

Conversation

timdorr
Copy link
Member

@timdorr timdorr commented Feb 2, 2017

Redo of #4436
Fixes #4362

beta.36 was pushed with lerna/lerna#566, which should fix the issue we were getting on install.

@timdorr
Copy link
Member Author

timdorr commented Feb 2, 2017

Welp...

@timdorr timdorr closed this Feb 2, 2017
@pshrmn
Copy link
Contributor

pshrmn commented Feb 2, 2017

Should the react-router-native tests even be run by TravisCI?

@timdorr
Copy link
Member Author

timdorr commented Feb 2, 2017

Yeah, they can be. They're just sanity checks for now: https://github.com/ReactTraining/react-router/blob/v4/packages/react-router-native/__tests__/index.ios.js

@kwelch
Copy link
Contributor

kwelch commented Feb 2, 2017

Would excluding hep at all? I cannot see what the failure was, but there are some settings in hoist.

@timdorr
Copy link
Member Author

timdorr commented Feb 2, 2017

I did that for react native ("nohoist": "react-native"), but that doesn't appear to be sufficient. If we end up excluding enough stuff, I'm not sure of the benefits of hoisting at all :/

@mjackson
Copy link
Member

mjackson commented Feb 2, 2017

react-router-native is a special little unicorn. I'm thinking about kicking it out of the monorepo and telling it to go live by itself in another repo...

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants