Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra StaticRouter createHref leading slash #4484

Merged
merged 1 commit into from Feb 7, 2017

Conversation

pshrmn
Copy link
Contributor

@pshrmn pshrmn commented Feb 7, 2017

Fixes #4480 Add a leading slash after concatenating this.props.basename and createURL(path).

// before
addLeadingSlash('') + '/my-path' = '//my-path'
// after
addLeadingSlash('' + '/my-path') = '/my-path'

@timdorr
Copy link
Member

timdorr commented Feb 7, 2017

Woot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants