Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic back button #5094

Closed
wants to merge 2 commits into from
Closed

Conversation

SeanGroff
Copy link
Contributor

I'm building off of pull request #5093. I'm submitting this as a separate pull request because i'm changing the public API of React-Router-Native. The reason I'm changing the public API is because of React-Native 0.44 the BackHandler now handles the back button on Android AND tvOS.

@timdorr
Copy link
Member

timdorr commented May 10, 2017

This would be a breaking API change. Perhaps re-export it as BackAndroidButtonto maintain compatibility and show a deprecation warning when it's used?

@timdorr
Copy link
Member

timdorr commented Jul 5, 2017

Closing in favor of #5295

@timdorr timdorr closed this Jul 5, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants