Use Jest projects for testing #5502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdorr
reviewed
Sep 8, 2017
| @@ -21,8 +21,7 @@ | |||
| "watch": "babel ./modules -d . --ignore __tests__ --watch", | |||
| "prepublishOnly": "node ./tools/build.js", | |||
| "clean": "git clean -fdX .", | |||
| "lint": "eslint modules", | |||
| "test": "jest" | |||
There was a problem hiding this comment.
Should we get rid of the test scripts in the individual packages? What if I want to watch on only one package?
There was a problem hiding this comment.
That is a good point. I don't know the full context of the project, so if this proposal does not align with the overall direction of the project, I totally understand 😄
There are a couple of options
- Jest allows to filter using a regex
jest --watch react-router-dom - You can call Jest with only that project
jest --projects packages/react-router-dom
timdorr
force-pushed
the
master
branch
2 times, most recently
from
fb3a586
to
f9481bb
Compare
timdorr
force-pushed
the
master
branch
4 times, most recently
from
8f33936
to
1fb8696
Compare
|
Thanks for the PR, @rogeliog, and sorry it took me so long to get around to reviewing it. I didn't even know about the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses jest
--projectsto handle multiple projectshttp://facebook.github.io/jest/docs/en/cli.html#projects-project1-projectn-