Native > Support Text as component #6451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi all, [since six months](facebook/react-native@e708010) the `react-native` implementation of `Text` implemented `forwardRef`. This means that, while a `Text` component is legit as a `Link` (it implements the `onPress` prop), it's not a function anymore. Instead, it will be an object with a render function. Unfortunately, the right prop type for `forwardRef` [does not exists yet](facebook/prop-types#200). This PR allows `Text` to be passed as `component` to `Link`, without `prop-types` warnings and maintaining a good level of safety checks. I hope you'll be ok with merging this, and thanks again for `react-router` 🙌
mjackson
reviewed
Nov 2, 2018
Add a reminder to replace the shape with the right prop-type when it'll be available.
|
Alternatively, you could go down the route that we did for |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
since six months the
react-nativeimplementation ofTextimplementedforwardRef. This means that, while aTextcomponent is legit as aLink(it implements theonPressprop), it's not a function anymore. Instead, it will be an object with a render function.Unfortunately, the right prop type for
forwardRefdoes not exists yet.This PR allows
Textto be passed ascomponenttoLink, withoutprop-typeswarnings and maintaining a good level of safety checks.I hope you'll be ok with merging this, and thanks again for
react-router🙌