Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing "update blocking" content #6652

Merged
merged 2 commits into from
May 15, 2019
Merged

Removing "update blocking" content #6652

merged 2 commits into from
May 15, 2019

Conversation

bradwestfall
Copy link
Contributor

@mjackson Just wanted to be sure this is all the content you wanted removed. Besides the "update blocking" page itself, two other pages made reference to it.

@bradwestfall bradwestfall changed the title Website dev Removing "update blocking" content Mar 21, 2019
@StringEpsilon StringEpsilon mentioned this pull request May 15, 2019
@timdorr
Copy link
Member

timdorr commented May 15, 2019

Can this get rebased against the latest website branch?

@bradwestfall
Copy link
Contributor Author

bradwestfall commented May 15, 2019

@timdorr Yes, are you asking if it should be done or for me to do it?

Michael asked me to update the content and this was my first go with the router->website workflow so I just made the PR so he could check the work to make sure I didn't break it. But he's been super busy with that workshop tour. So if you wanted to review/rebase/merge that would be great

@timdorr
Copy link
Member

timdorr commented May 15, 2019

If you don't mind. I can take care of the review and merge.

@bradwestfall
Copy link
Contributor Author

Perfect, thank you

@timdorr
Copy link
Member

timdorr commented May 15, 2019

Confirmed it looked good locally. I'll wait for Travis and then merge it in.

@timdorr timdorr merged commit 97f0eee into website May 15, 2019
@timdorr timdorr deleted the website-dev branch May 15, 2019 19:08
@damir-sirola
Copy link

Hi, I found this page to be very helpful as I encountered the problem with my components not rendering. The reason is described very well in the deleted page. If you are able to provide some context about why it was removed it I would really appreciate it?

@bradwestfall
Copy link
Contributor Author

The docs generally reflect the latest version, in version 5 the problem isn't there anymore. In fact, v5 is basically the same API as 4 but with some internal fixes like this so migrating should be easy. Checkout this which Michael wrote about it https://reacttraining.com/blog/react-router-v5/

@damir-sirola
Copy link

Thank you for the answer

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants