Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default value for context in StaticRouter.navigateTo #6698

Merged
merged 1 commit into from Apr 9, 2019
Merged

Add a default value for context in StaticRouter.navigateTo #6698

merged 1 commit into from Apr 9, 2019

Conversation

sumanvyj
Copy link
Contributor

@sumanvyj sumanvyj commented Apr 9, 2019

If you instantiate StaticRouter without providing a context object and attempt to render e.g. a Redirect, an error is thrown because context will be undefined.

@timdorr
Copy link
Member

timdorr commented Apr 9, 2019

Thanks!

@timdorr timdorr merged commit 3ccbd19 into remix-run:master Apr 9, 2019
@sumanvyj sumanvyj deleted the patch-1 branch April 11, 2019 19:28
@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants