Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo: useMatch -> useRouteMatch #6948

Merged
merged 1 commit into from
Sep 29, 2019
Merged

typo: useMatch -> useRouteMatch #6948

merged 1 commit into from
Sep 29, 2019

Conversation

crossjs
Copy link
Contributor

@crossjs crossjs commented Sep 29, 2019

No description provided.

@pshrmn pshrmn merged commit bb9b4fd into remix-run:master Sep 29, 2019
@pshrmn
Copy link
Contributor

pshrmn commented Sep 29, 2019

Thanks!

@crossjs crossjs deleted the typo-useMatch branch September 29, 2019 14:46
@perrin4869
Copy link
Contributor

Just out of curiosity, why wasn't the hook named useMatch?

@MeiKatz
Copy link
Contributor

MeiKatz commented Sep 29, 2019

I think match is a very broad term. route match makes things more clear.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crossjs @pshrmn @perrin4869 @MeiKatz