Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace deprecated "componentWillMount" with "componentDidMount" #7259

Merged

Conversation

theboolean
Copy link
Contributor

No description provided.

@timdorr
Copy link
Member

timdorr commented Apr 14, 2020

Thanks!

@timdorr timdorr merged commit c0b8ce4 into remix-run:master Apr 14, 2020
@mjackson
Copy link
Member

This change fundamentally alters how this code works but doesn't provide any tests or rationale for the change. Reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants