Fix greedy trailing * bug #7874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't realize this fixed caused another bug 🤦♂️ Looking into it now to see if I can solve it |
brookslybrand
commented
Jun 15, 2021
| @@ -884,7 +884,7 @@ export function matchPath( | |||
| let matchedPathname = match[1]; | |||
| let values = match.slice(2); | |||
| let params = paramNames.reduce((memo, paramName, index) => { | |||
| memo[paramName] = safelyDecodeURIComponent(values[index], paramName); | |||
| memo[paramName] = safelyDecodeURIComponent(values[index] || '', paramName); | |||
There was a problem hiding this comment.
@mjackson Our updated regex below made it to where nothing matches for the final group in the case where the path is "react/*" and the pathname is "react". This meant we were getting undefined for that group's value, which cause the decoding to fail.
Everything is passing now with this simple fix, but let me know if this is a problem or if I should instead investigate fixing this at the expression building step inside of compilePath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7529