Added location param override to Routes #7969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2021
[Feature]: Allow to override the location in the Routes in V6, like in the modal example in V5
#7949
Closed
|
See my notes here: #7945 We aren't yet sure this is the right API for v6, but we are committed to solving the underlying need before v1. |
chaance
approved these changes
Sep 1, 2021
|
Ok, we're adding this back 😄 Fixes #7117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the posibility to override the location in the Routes component, like it was possible in Switch in V5.
Useful for implementing logic like in the example:
https://reactrouter.com/web/example/modal-gallery
Specific test added