Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore basename casing when matching #8000

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Ignore basename casing when matching #8000

merged 2 commits into from
Sep 3, 2021

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented Sep 3, 2021

Fixes #7997

mjackson
mjackson requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@mjackson mjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to lower-case the pathname as well, and probably add a test for weird uppercase URLs coming through to make sure they match differently-cased basenames.

@chaance chaance merged commit 5ad81a8 into dev Sep 3, 2021
@chaance chaance mentioned this pull request Sep 3, 2021
Closed
@chaance chaance deleted the case-insensitive-basename branch September 3, 2021 21:59
@mcansh mcansh mentioned this pull request Sep 21, 2021
Merged
brophdawg11 pushed a commit that referenced this pull request Mar 27, 2024
@hi-ogawa @markdalgleish
test(remix-dev/vite): add Vanilla Extract to CSS tests (#8000)
f330a04 
Co-authored-by: Mark Dalgleish <mark.john.dalgleish@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjackson mjackson mjackson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chaance @mjackson