history was missed as a peer dep

[maraisr]

Check;

react-router/packages/react-router-dom/server.tsx

Line 2 in 4ae8f46

import { Action, Location, To, createPath, parsePath } from "history";

Currently not able to bundle react-rotuer-dom, as there is no dep on history in the file tree.

Worth noting seems to be only if pnpm is used, maybe just different linking strategy between it and yarn/npm.

[ryanflorence]

It's a direct dependency now, maybe your package-lock needs to be updated?

react-router/packages/react-router/package.json

Line 20 in 4ae8f46

"history": "^5.0.3"

[jacob-ebey]

It's a direct dependency now, maybe your package-lock needs to be updated?

react-router/packages/react-router/package.json

Line 20 in 4ae8f46

"history": "^5.0.3"

We are importing "history" in "react-router-dom" without it existing directly in the package.json. It only exists in the package.json of "react-router". We will want to add it to "react-router-dom" 's package.json deps as well since it does in-fact directly import / re-export from history.

[maraisr]

Ya in anycase, history is directly used by -dom — and not referenced in any of its package.json fields.

Ill let you guys decide if its a direct dep or a peerDep.

Just let me know when this is ready, and not sure when/if this is a regression — coz we've been on v6 alpha for quite a while with no issues.

[mjackson]

History is a direct dependency. We need to do the same for react-router-native too.

[timdorr]

History is a direct dependency. We need to do the same for react-router-native too.

Done. I'll wait for tests to pass and merge it in.

[maraisr]

Thanks for being so swift with this done @timdorr 🤝

Just wondering how long till this lands on npm?

[maraisr]

Ah thanks for that one @timdorr — can see its now in v6.0.1.