Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] allow a StaticLocation to be passed directly when creating a router #836

Merged
merged 1 commit into from
Feb 14, 2015
Merged

Conversation

insin
Copy link
Contributor

@insin insin commented Feb 14, 2015

Converting from StringStaticLocation up front allows this.

Discovered this while testing server-side rendering of #828, where a StaticLocation must be passed to provide a payload.

mjackson added a commit that referenced this pull request Feb 14, 2015
[fixed] allow a StaticLocation to be passed directly when creating a router
@mjackson mjackson merged commit 8276235 into remix-run:master Feb 14, 2015
@mjackson
Copy link
Member

@insin Perfect. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants