Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in docs #8455

Merged
merged 5 commits into from Dec 8, 2021
Merged

Fix grammar in docs #8455

merged 5 commits into from Dec 8, 2021

Conversation

RobHannay
Copy link
Contributor

@RobHannay RobHannay commented Dec 8, 2021

Minor: Possessive "its" rather than contracted "it is"

This grew from the original fix to me doing a sweep of the docs as a whole. I've left some more "stylistic" grammar points as they are, and tried only to fix the ones that are more black and white. Hope they're helpful but feel free to remove any specific changes if they're unhelpful. Thanks!

Possessive "its" rather than contracted "it is"
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 8, 2021

Hi @RobHannay,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 8, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 8, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@RobHannay RobHannay changed the title Fix minor grammar in overview.md Fix minor grammar (possessive "its") in docs Dec 8, 2021
@RobHannay RobHannay changed the title Fix minor grammar (possessive "its") in docs Fix grammar in docs Dec 8, 2021
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 8, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Dec 8, 2021

Thank's!

@timdorr timdorr merged commit 5730e28 into remix-run:main Dec 8, 2021
@RobHannay RobHannay deleted the patch-1 branch December 8, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants