Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs only): verbiage fixes in Getting Started docs #8462

Merged
merged 2 commits into from Dec 9, 2021

Conversation

brockross
Copy link
Contributor

Found a couple missing words while reading the "Definitions" section of the Getting Started docs. Added them to improve readability.

I didn't see any further guidelines for PR format in the Contributing guide, but please let me know if I need to do something different. Thanks gang! 馃

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 9, 2021

Hi @brockross,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 9, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 馃コ

@@ -33,9 +33,9 @@ Here are some words we use a lot when we talk about React Router. The rest of th

- <a id="history-stack">**History Stack**</a> - As the user navigates, the browser keeps track of each [location](#location) in a stack. If you click and hold the back button in a browser you can see the browser's history stack right there.

- <a id="csr">**Client Side Routing (CSR)**</a> - A plain HTML document can link to other documents and the browser handles the [history stack](#history-stack) itself. Client Side Routing enables developers to manipulate the browser history stack without making document request to the server.
- <a id="csr">**Client Side Routing (CSR)**</a> - A plain HTML document can link to other documents and the browser handles the [history stack](#history-stack) itself. Client Side Routing enables developers to manipulate the browser history stack without making a document request to the server.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would also make sense as "... without making document requests to the server." Let me know if that's preferable!

@timdorr
Copy link
Member

timdorr commented Dec 9, 2021

Thanks!

@timdorr timdorr merged commit 174c2cf into remix-run:main Dec 9, 2021
brophdawg11 added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants