Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated reach migration guide for Route Components #8491

Merged
merged 2 commits into from Dec 16, 2021

Conversation

vijaypushkin
Copy link
Contributor

@vijaypushkin vijaypushkin commented Dec 16, 2021

Upon going through the source code, I found only Route components are allowed inside Routes, Hence updated the doc examples as such

Upon going through the source code, I found only `Route` components are allowed inside `Routes`, Hence updated the doc examples as such
@remix-cla-bot
Copy link
Contributor

@remix-cla-bot remix-cla-bot bot commented Dec 16, 2021

Hi @vijaypushkin,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

@remix-cla-bot remix-cla-bot bot commented Dec 16, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Collaborator

@timdorr timdorr commented Dec 16, 2021

Thanks!

@timdorr timdorr merged commit eeb7a57 into remix-run:main Dec 16, 2021
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants