Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to comment on issues/PRs about new releases #8981

Merged
merged 6 commits into from
Jun 22, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Jun 14, 2022

this takes our approach from remix-run/remix and ups it a notch by using workflow_call instead of using a repository_dispatch call which is more in-tune with proper reusability - I've back ported that to remix here remix-run/remix#3470

@mcansh mcansh force-pushed the logan/comment-on-release branch 5 times, most recently from 099616a to bfc0c7c Compare June 14, 2022 15:31
this takes our approach from remix-run/remix and ups it a notch by using `workflow_call` instead of using a repo dispatch call which is more in-tune with proper reusability
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh marked this pull request as ready for review June 14, 2022 15:44
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
This reverts commit e0d0d4f.

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍 @ryanflorence do you want to review this since it's on the router repo?

@kentcdodds kentcdodds merged commit 1b636aa into main Jun 22, 2022
@kentcdodds kentcdodds deleted the logan/comment-on-release branch June 22, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants