Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #9011 useParams()'s new {} return #9012

Closed
wants to merge 1 commit into from

Conversation

JasonKleban
Copy link

@JasonKleban JasonKleban commented Jun 24, 2022

Addresses #9011 useParams()'s new {} return.

This might be made more general (covering more than the special case of a falsey routeMatch)

Addresses remix-run#9011 useParams()'s new `{}` return
@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2022

⚠️ No Changeset found

Latest commit: 9cd80a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 24, 2022

Hi @JasonKleban,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@JasonKleban
Copy link
Author

I'm not trying to get in so deep with that CLA so feel free to steal this simple change if you like it exactly as-is.

@timdorr timdorr closed this Jun 26, 2022
brophdawg11 added a commit that referenced this pull request Mar 27, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Brophy <matt@brophy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants