Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support basename in static routers #9591

merged 6 commits into from Nov 23, 2022


Copy link

@brophdawg11 brophdawg11 commented Nov 14, 2022

Adds support for basename to static data routers. We accept it up front in createStaticHandler, and then persist it through createStaticRouter/StaticRouterPRovider

Sample usage:

let { query } = createStaticHandler(routes, { basename: '/base '});
let context = await query(request);
let router = createStaticRouter(routes, context);

return ReactDOMServer.renderToString(
  <StaticRouterProvider router={router} context={context} />

Copy link

changeset-bot bot commented Nov 14, 2022

🦋 Changeset detected

Latest commit: e471d01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router-dom Patch
@remix-run/router Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -64,7 +64,6 @@ export function StaticRouter({

export interface StaticRouterProviderProps {
basename?: string;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To align with <RouterProvider> we no longer accept a basename as a prop, we inherit from the router passed to it. In the SSR case, that further inherits from the static handler.

@brophdawg11 brophdawg11 merged commit f9652c6 into dev Nov 23, 2022
2 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/static-router-basename branch November 23, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants