Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up generatePath when optional params are present #9764

Merged
merged 6 commits into from
Jan 11, 2023

Conversation

brophdawg11
Copy link
Contributor

Closes #9736

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2022

🦋 Changeset detected

Latest commit: 7e7e3ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router Patch
@remix-run/router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -614,7 +616,7 @@ function matchRouteBranch<
export function generatePath<Path extends string>(
originalPath: Path,
params: {
[key in PathParam<Path>]: string;
[key in PathParam<Path>]: string | null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our types still require you pass the key so accept null for optional params.

@brophdawg11 brophdawg11 merged commit de3c96a into dev Jan 11, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/generate-path-optional branch January 11, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: generatePath doesn't work with optional params (v6.5.0-pre.1)
2 participants