Improved absolute redirect url detection in actions/loaders #9829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue remix-run/remix#5002.
With this change, we are able to redirect to URI's like
mailto:mail@example.com
before this change it was not possible because it was interpreted as a relative path.The regex comes from https://stackoverflow.com/a/31991870 and should match all common absolute URLs and URIs including string starting with
//
.I tested it with in my own project and it worked like a charm!