fix: pr review Michael

remix-run · Jun 24, 2022 · d89d17c · d89d17c
1 parent d48bcc5
commit d89d17c
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 15 deletions.
diff --git a/packages/remix-cloudflare/package.json b/packages/remix-cloudflare/package.json
@@ -21,9 +21,7 @@
     "@cloudflare/workers-types": "^3.4.0"
   },
   "peerDependencies": {
-    "@cloudflare/workers-types": "^2.0.0 || ^3.0.0",
-    "react": ">=16.8",
-    "react-dom": ">=16.8"
+    "@cloudflare/workers-types": "^2.0.0 || ^3.0.0"
   },
   "engines": {
     "node": ">=14"

diff --git a/packages/remix-deno/package.json b/packages/remix-deno/package.json
@@ -17,10 +17,6 @@
     "@remix-run/server-runtime": "1.6.1",
     "mime": "^3.0.0"
   },
-  "peerDependencies": {
-    "react": ">=16.8",
-    "react-dom": ">=16.8"
-  },
   "engines": {
     "node": ">=14"
   }

diff --git a/packages/remix-dev/cli/create.ts b/packages/remix-dev/cli/create.ts
@@ -210,7 +210,7 @@ export async function createApp({
       npmConfig = execSync(`${packageManager} config get @remix-run:registry`, {
         encoding: "utf8",
       });
-    } catch (error: unknown) {
+    } catch {
       // Yarn throws when it can't find a "@remix-run:registry" configuration setting
     }
     if (npmConfig?.startsWith("https://npm.remix.run")) {

diff --git a/packages/remix-dev/package.json b/packages/remix-dev/package.json
@@ -76,9 +76,7 @@
     "type-fest": "^2.12.2"
   },
   "peerDependencies": {
-    "@remix-run/serve": "1.5.1",
-    "react": ">=16.8",
-    "react-dom": ">=16.8"
+    "@remix-run/serve": "1.5.1"
   },
   "peerDependenciesMeta": {
     "@remix-run/serve": {

diff --git a/packages/remix-node/package.json b/packages/remix-node/package.json
@@ -29,10 +29,6 @@
     "@types/cookie-signature": "^1.0.3",
     "@types/source-map-support": "^0.5.4"
   },
-  "peerDependencies": {
-    "react": ">=16.8",
-    "react-dom": ">=16.8"
-  },
   "engines": {
     "node": ">=14"
   },

diff --git a/packages/remix-server-runtime/package.json b/packages/remix-server-runtime/package.json
@@ -33,6 +33,14 @@
     "react": ">=16.8",
     "react-dom": ">=16.8"
   },
+  "peerDependenciesMeta": {
+    "react": {
+      "optional": true
+    },
+    "react-dom": {
+      "optional": true
+    }
+  },
   "engines": {
     "node": ">=14"
   },