Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should raise error when app/routes/index.jsx does not exist #4623

Closed
WesleyYue opened this issue Nov 16, 2022 · 0 comments · Fixed by #6489
Closed

Should raise error when app/routes/index.jsx does not exist #4623

WesleyYue opened this issue Nov 16, 2022 · 0 comments · Fixed by #6489
Labels
docs feat:dx Issues related to the developer experience

Comments

@WesleyYue
Copy link

What version of Remix are you using?

1.4.3

Steps to Reproduce

  1. Clone https://github.com/WesleyYue/incremental-react-router-to-remix-upgrade-path
  2. npm install
  3. npm run dev

Expected Behavior

There should be some kind of error that informs the user that they cannot use the catch-all route to render /. This is super non-obvious if migrating from react-router and the user will almost certainly have / as a path under their old react-router implementation. I waste a few hours trying to figure out why my migration didn't work and it's super frustrating to debug. The migration guide does not say anything about needing this index.[jsx/tsx].

Actual Behavior

No error anywhere, just empty rendered by the browser if you follow the migration guide step by step.

@machour machour added docs feat:dx Issues related to the developer experience labels Nov 30, 2022
vcheeze added a commit to vcheeze/remix that referenced this issue Mar 20, 2023
@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 30, 2023
@remix-run remix-run deleted a comment from github-actions bot Apr 30, 2023
@machour machour removed needs-response We need a response from the original author about this issue/PR bug:unverified labels Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs feat:dx Issues related to the developer experience
Projects
None yet
2 participants