docs(guides/migrating-react-router-app): add a warning notice #5847
Conversation
Addresses remix-run#4623
|
|
Hi @vcheeze, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
MichaelDeBoey
changed the title
| @@ -184,6 +184,8 @@ Inside of your `$.jsx` file, all we need to do is export the code from our old r | |||
| export { default } from "~/old-app/app"; | |||
| ``` | |||
|
|
|||
| <docs-warning><strong>Important:</strong> make sure `app/routes/index.[jsx|tsx]` exists in your Remix app. Remix will not automatically render your `/` React Router fallback route, which means a blank page will be rendered without the index file in the `routes` directory.</docs-warning> | |||
|
|
|||
There was a problem hiding this comment.
Instead of using a warning here, could we just change the section to be "Create an Index and a Catch-all route" and export your old app (i.e., <Routes> tree) from both?
MichaelDeBoey
added
the
needs-response
|
This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you have more information for us! 🙂 |
Closes #4623