-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remix v1.16.1 fail to start ESM app server with tsx watch on Windows #6504
Comments
There is an easy fix updating this code fix the issue remix/packages/remix-dev/devServer_unstable/index.ts Lines 69 to 79 in 761fc1d
let newAppServer = execa.command(command, {
- stdio: "pipe",
+ stdio: ['ignore', 'pipe', 'pipe'],
+ shell: true,
env: {
NODE_ENV: "development",
PATH:
bin + (process.platform === "win32" ? ";" : ":") + process.env.PATH,
REMIX_DEV_HTTP_ORIGIN: stringifyOrigin(httpOrigin),
},
// https://github.com/sindresorhus/execa/issues/433
windowsHide: false,
}); EDIT
|
Ah, that explains why I couldn't get tsx watch to work on Windows. Can confirm the fix solved it! |
Seems like Epic Stack resorted to a hack using https://github.com/epicweb-dev/epic-stack/blob/main/server/dev-server.js#L9 |
Fixes remix-run#6504 This is an issue noted on Epic Stack as well, forcing a patch with `execa`: * https://github.com/epicweb-dev/epic-stack/blob/main/server/dev-server.js#L9 * epicweb-dev/epic-stack#136
Fixes remix-run#6504 This is an issue noted on Epic Stack as well, forcing a patch with `execa`: * https://github.com/epicweb-dev/epic-stack/blob/main/server/dev-server.js#L9 * epicweb-dev/epic-stack#136
Closing as this seems to be a bug in |
There is already a PR in |
What version of Remix are you using?
1.16.1
Are all your remix dependencies & dev-dependencies using the same version?
Steps to Reproduce
With this configuration on Windows Remix fails to start custom server
configuration:
tsx watch
remix dev -c "tsx watch ./server.js"
You can reproduce this issue by installing @kentcdodds excellent
epic-stack
npx create-remix@latest --typescript --install --template epicweb-dev/epic-stack
npm i -D chalk@5.2.0
Expected Behavior
App running:
Actual Behavior
App not running
The text was updated successfully, but these errors were encountered: