-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs,examples,templates): make npm-run-all
calls work when using Yarn
#3595
The head ref may contain hidden characters: "\u{1F3C3}"
Conversation
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
run-p
with Yarn
run-p
with Yarnrun-p
work when using Yarn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already had #2417 to start working on this.
Since it didn't get any response in the last 25 days, I'd rather get this one merged instead.
1 thing I want to do here too though is also update all run-s
calls as well.
I also prefer using single quotes tbh, as that makes it a bit more easy on the eyes (and has a lower cognitive load as well, since you don't need to think about where you are in the script & if you have escaped all of the correctly)
run-p
work when using Yarnnpm-run-all
calls work when using Yarn
@MichaelDeBoey consider it done! |
37fd0f9
to
d6d0014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure single quotes make this not work on windows. I've never heard of needing to quote these npm-run-all usages for Windows support 🤔
@kentcdodds fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🤖 Hello there, We just published version Thanks! |
run-p dev:*
doesn’t (but probably should) work with Yarn. Thankfully, this can be fixed quite easily by wrapping the argument in quotes.(As an aside, I find single quotes a bit cleaner than escaped double quotes, but I saw that escaped quotes were already used elsewhere so I stuck to the convention.)