Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(experimental): add deno for typechecking deno files #4847

Closed

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Dec 12, 2022

x-ref: #4715

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #

  • Docs
  • Tests

Testing Strategy:

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2022

⚠️ No Changeset found

Latest commit: 29957a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh changed the title ci: install deno ci(experimental): add deno for typechecking deno files Dec 12, 2022
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 39bf881)
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit afff146)
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 395e93f)
Comment on lines +8 to +11
"@remix-run/deno": "https://esm.sh/@remix-run/deno@latest",
"@remix-run/server-runtime": "https://esm.sh/@remix-run/server-runtime@latest",
"@remix-run/dev/server-build": "https://esm.sh/@remix-run/dev@latest/server-build",
"@remix-run/react": "https://esm.sh/@remix-run/react@latest",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be the exact version we have in package.json (ie currently 1.8.2)?

People will have to update these consciously when also updating package.json versions.
People will also have errors when v2 will be released otherwise

Suggested change
"@remix-run/deno": "https://esm.sh/@remix-run/deno@latest",
"@remix-run/server-runtime": "https://esm.sh/@remix-run/server-runtime@latest",
"@remix-run/dev/server-build": "https://esm.sh/@remix-run/dev@latest/server-build",
"@remix-run/react": "https://esm.sh/@remix-run/react@latest",
"@remix-run/deno": "../node_modules/@remix-run/deno/index.ts",
"@remix-run/server-runtime": "https://esm.sh/@remix-run/server-runtime@1.8.2",
"@remix-run/dev/server-build": "https://esm.sh/@remix-run/dev@1.8.2/server-build",
"@remix-run/react": "https://esm.sh/@remix-run/react@1.8.2",

@mcansh mcansh closed this Dec 17, 2022
@mcansh mcansh deleted the logan/bundle-dep-deno branch December 17, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants