-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(experimental): add deno for typechecking deno files #4847
ci(experimental): add deno for typechecking deno files #4847
Conversation
Signed-off-by: Logan McAnsh <logan@mcan.sh>
|
bdbb5aa
to
29957a3
Compare
"@remix-run/deno": "https://esm.sh/@remix-run/deno@latest", | ||
"@remix-run/server-runtime": "https://esm.sh/@remix-run/server-runtime@latest", | ||
"@remix-run/dev/server-build": "https://esm.sh/@remix-run/dev@latest/server-build", | ||
"@remix-run/react": "https://esm.sh/@remix-run/react@latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these be the exact version we have in package.json
(ie currently 1.8.2
)?
People will have to update these consciously when also updating package.json
versions.
People will also have errors when v2 will be released otherwise
"@remix-run/deno": "https://esm.sh/@remix-run/deno@latest", | |
"@remix-run/server-runtime": "https://esm.sh/@remix-run/server-runtime@latest", | |
"@remix-run/dev/server-build": "https://esm.sh/@remix-run/dev@latest/server-build", | |
"@remix-run/react": "https://esm.sh/@remix-run/react@latest", | |
"@remix-run/deno": "../node_modules/@remix-run/deno/index.ts", | |
"@remix-run/server-runtime": "https://esm.sh/@remix-run/server-runtime@1.8.2", | |
"@remix-run/dev/server-build": "https://esm.sh/@remix-run/dev@1.8.2/server-build", | |
"@remix-run/react": "https://esm.sh/@remix-run/react@1.8.2", |
x-ref: #4715
Signed-off-by: Logan McAnsh logan@mcan.sh
Closes: #
Testing Strategy: