Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-react): show deprecation warning when imagesizes & imagesizes properties are returned from links function #5706

Merged
merged 2 commits into from Mar 21, 2023
Merged

feat(remix-react): show deprecation warning when imagesizes & imagesizes properties are returned from links function #5706

merged 2 commits into from Mar 21, 2023

Conversation

MichaelDeBoey
Copy link
Member

This will warn people about #5705

@MichaelDeBoey MichaelDeBoey added renderer:react feat:links-meta Issues related to links()/meta() labels Mar 8, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023 •
edited

🦋 Changeset detected

Latest commit: b72bc8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Minor
@remix-run/testing Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/node Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the show-links-deprecation-warning branch from 87d54ac to 696f79d Compare March 8, 2023 00:38
@MichaelDeBoey MichaelDeBoey force-pushed the show-links-deprecation-warning branch 2 times, most recently from 6bad63c to 92035a1 Compare March 15, 2023 11:06
@MichaelDeBoey MichaelDeBoey force-pushed the show-links-deprecation-warning branch 2 times, most recently from aa37a6d to eb5fe59 Compare March 16, 2023 02:00
@MichaelDeBoey
feat(remix-react): show deprecation warning when imagesizes & `imag…
ca0edff 
…esizes` properties are returned from `links` function
@brophdawg11 brophdawg11 merged commit 85cf35d into remix-run:dev Mar 21, 2023
8 of 9 checks passed
@mcansh mcansh mentioned this pull request Mar 21, 2023
Merged
@brophdawg11 brophdawg11 mentioned this pull request Mar 21, 2023
Merged
@MichaelDeBoey MichaelDeBoey deleted the show-links-deprecation-warning branch March 21, 2023 20:12
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-d6c9737-20230322 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@mcansh
Copy link
Collaborator

mcansh commented Mar 22, 2023

couple things i'm seeing with this:

  1. i don't have any instances of imagesizes or imagesrcset
  2. i'm seeing this warning in production 😬

image

@mcansh
Copy link
Collaborator

mcansh commented Mar 22, 2023

PR to fix #5874

@mcansh mcansh mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour Awaiting requested review from machour

@brophdawg11 brophdawg11 Awaiting requested review from brophdawg11

@chaance chaance Awaiting requested review from chaance

@mcansh mcansh Awaiting requested review from mcansh

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees
No one assigned
Labels
CLA Signed feat:links-meta Issues related to links()/meta() renderer:react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelDeBoey @mcansh @brophdawg11