Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-react): don't warn about runtime deprecation warnings in production #5874

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Mar 22, 2023

Closes: #

  • Docs
  • Tests

Testing Strategy:

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023

🦋 Changeset detected

Latest commit: d963100

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh changed the title fix: add NODE_ENV check to warnOnce fix(remix-react): add NODE_ENV check to warnOnce Mar 22, 2023
@mcansh mcansh changed the title fix(remix-react): add NODE_ENV check to warnOnce fix(remix-react): don't warn about runtime deprecation warnings in production Mar 22, 2023
@mcansh mcansh merged commit 10187ee into release-next Mar 22, 2023
@mcansh mcansh deleted the logan/react-warn-prod branch March 22, 2023 16:56
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.15.0-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

mcansh added a commit that referenced this pull request Mar 25, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-98dee11-20230331 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.15.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants