Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): do not clear screen when dev server starts #6719

Merged
merged 1 commit into from Jun 28, 2023
Merged

fix(dev): do not clear screen when dev server starts #6719

merged 1 commit into from Jun 28, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jun 28, 2023 •
edited

Fixes #6709

on some terminal emulators, "clearing" only scrolls the next line to the top. on others, it erases the scrollback.

instead, let users call clear themselves (clear && remix dev) if they want to clear

Closes: #

  • Docs
  • Tests

Testing Strategy:

@pcattori
fix(dev): do not clear screen when dev server starts
9766aa7 
on some terminal emulators, "clearing" only scrolls the next line to the
top. on others, it erases the scrollback.

instead, let users call `clear` themselves (`clear && remix dev`) if
they want to clear
@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

🦋 Changeset detected

Latest commit: 9766aa7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori linked an issue Jun 28, 2023 that may be closed by this pull request
dev 1.18.0 is clearing my terminal #6709
Closed
1 task
@pcattori pcattori merged commit 3775f30 into dev Jun 28, 2023
9 checks passed
@pcattori pcattori deleted the pedro/fix-dev-clear branch June 28, 2023 19:04
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jun 28, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-4ef7a88-20230629 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-0657c16-20230630 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.18.1-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-7abaf9f-20230701 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@pcattori pcattori mentioned this pull request Jul 5, 2023
Closed
2 tasks
@github-actions github-actions bot mentioned this pull request Jul 13, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev 1.18.0 is clearing my terminal
1 participant
@pcattori