Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev): allow emitting serverBuildPath as cjs #7348

Closed
wants to merge 1 commit into from
Closed

fix(remix-dev): allow emitting serverBuildPath as cjs #7348

wants to merge 1 commit into from

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Sep 6, 2023 •
edited
Loading

in my opinion this should be back ported into remix v1

see remix-run/indie-stack#255 (comment) for rational

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 63b5e5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh mentioned this pull request Sep 6, 2023
Open
@MichaelDeBoey MichaelDeBoey changed the title fix(remix-dev): allow emitting serverBuildPath as cjs fix(remix-dev): allow emitting serverBuildPath as cjs Sep 6, 2023
MichaelDeBoey
MichaelDeBoey approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my opinion this should be back ported into remix v1

I agree we should release this as 1.19.4

@mcansh
fix(remix-dev): allow emitting serverBuildPath as cjs
63b5e5d 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh mentioned this pull request Sep 6, 2023
Closed
2 tasks
@MichaelDeBoey MichaelDeBoey mentioned this pull request Sep 6, 2023
Draft
@lpsinger
Copy link
Contributor

lpsinger commented Sep 7, 2023

Duplicate of #7180.

@mcansh
Copy link
Collaborator Author

mcansh commented Sep 7, 2023

closing in favor of #7180

@mcansh mcansh closed this Sep 7, 2023
@mcansh mcansh deleted the mcansh-patch-1 branch September 7, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@pcattori pcattori Awaiting requested review from pcattori

@brophdawg11 brophdawg11 Awaiting requested review from brophdawg11

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcansh @lpsinger @MichaelDeBoey