templates(deno): use built in http server #9210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wangbinyq
commented
Apr 10, 2024
|
|
||
| const remixHandler = createRequestHandlerWithStaticFiles({ | ||
| build, | ||
| getLoadContext: () => ({}), | ||
| }); | ||
|
|
||
| const port = Number(Deno.env.get("PORT")) || 8000; | ||
| console.log(`Listening on http://localhost:${port}`); |
There was a problem hiding this comment.
Remove this, as Deno.serve logs by default.
|
Verified that I'm able to run dev, build, and start all with this change, and that the port is auto logged Gonna go ahead and merge this. |
MichaelDeBoey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deno std http server is marked as deprecated, and
Deno.serveis the preferred api to use.https://deno.land/std@0.221.0/http/server.ts
https://docs.deno.com/runtime/manual/runtime/http_server_apis