Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new webhook events #24

Closed
3 tasks
remixz opened this issue Jul 1, 2016 · 2 comments
Closed
3 tasks

Add support for new webhook events #24

remixz opened this issue Jul 1, 2016 · 2 comments

Comments

@remixz
Copy link
Owner

remixz commented Jul 1, 2016

Here are the ones we're missing now:

Should be a pretty simple matter of just adding them to the _handleMessage function (https://github.com/remixz/messenger-bot/blob/master/index.js#L95), and then adding tests.

@remixz
Copy link
Owner Author

remixz commented Jul 1, 2016

Actually, we already have basic support for the message echo event, as it'll be captured by our message event callback. However, because I think most people would rather not handle their own messages as incoming messages, I think we should create a new event by checking if the is_echo param is on the incoming payload, and then delegate based on that.

@eXeDK
Copy link
Collaborator

eXeDK commented Jul 6, 2016

Have a look at the #26 pull request, should do this. Sadly I didn't see your issues before I wrote the code.

@remixz remixz closed this as completed Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants