Support for Messenger Platform 1.1 features

[eXeDK]

No description provided.

[coveralls]

Coverage decreased (-25.6%) to 74.39% when pulling 5bc3b89 on eXeDK:master into 1ac973a on remixz:master.

[danvass]

@remixz Can you merge this please?

[adamjace]

please merge @remixz

[victorcotap]

Please merge @remixz

[Naramsim]

Please Merge and huge thanks to @eXeDK 🎆

[Naramsim]

Would be useful to add: https://developers.facebook.com/docs/messenger-platform/thread-settings/greeting-text

To show an initial greeting 😄

[iMicknl]

Coverage decreased (-25.6%) to 74.39% when pulling 5bc3b89 on eXeDK:master into 1ac973a on remixz:master.

Why are there no tests included? I think it is quite important to add some tests, before this will be merged.

[eXeDK]

Bump

[remixz]

@eXeDK Hey! Thanks for your contribution 😄, sorry I'm so late. I'll agree with @iMicknl that tests should be included for 100% coverage, plus we'd probably want documentation as well. However, I'm gonna add you as a contributor to this repo now, since you've been super helpful in other issues, which I really appreciate. If you want to merge this just to get things started, and work on tests later, go for it. I'll make sure to keep an eye on things, and do a release once everything's good.

[charlesaraya]

if (event.message.is_echo) { ... } would be enough.

[adamjace]

not true. you would get a typeError if message was undefined

[charlesaraya]

Correct.

if (event.message) {
    if (event.message.is_echo) {
         this._handleEvent('echoMessage', event)
    } else {
         this._handleEvent('message', event)
    }
}

[charlesaraya]

It should be if ... else if ... else instead of a whole bunch of if's. It's a waste of execution time to keep checking falsy conditions, since calbacks types are muatually exclusive. For better performance use switch (Writting Efficient Javascript).

Plus, I would handle unknown events:

if (event.oneCallbackType) {
    ... handle it ...
} else if (event.othercallbackType) {
    ... handle it ...
} else if ( ... ){    // as many as needed
    ... handle these too ...
} else {
    console.error('Webhook received an unknown messaging event: ', JSON.stringify(event))
} 

[coveralls]

Coverage decreased (-7.5%) to 92.473% when pulling f36ecca on eXeDK:master into 1ac973a on remixz:master.

[remixz]

I went ahead and finished this PR with full test coverage and documentation. Thank you for your hard work on this! Released as 2.4.0.