-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility of sending message with tag #89
Conversation
Add the function `sendMessageWithTag(recipient, payload, tag, cb)` which allows sending messages with the specified tag.
Add the documentation for the function `sendMessageWithTag()`.
Please fix tests @baudev |
Fixing continuous integration test failing 'cause of JavaScript Standard Style
Adding missing space making fail the continuous integration test.
Test passed on Node v6 ! https://travis-ci.org/remixz/messenger-bot/jobs/385714367 |
What about Node4? I have not setup these pipelines so I'm not sure I can make changes to those. |
The mentioned errors in Node4 don't seem to be related to my MR. EDIT : Sorry for closing the MR. Mistake on my part. |
Give more flexibility to the `sendMessage()` function by letting the possibility of choosing the `messaging_type` attribute. Then remove the sendMessageWithTag() function.
Update the documentation for the sendMessage() function. Remove it for sendMessageWithTag() one.
The function could be used as following finally : bot.sendMessage(payload.sender.id, {"text": "message_test"}, (error, body) => {
// ...
}, 'MESSAGE_TAG', 'NON_PROMOTIONAL_SUBSCRIPTION'); |
This issue's comment istanbuljs/nyc#865 (comment) explains that We have two options:
I prefer the last solution: easier and more secure. Then it requires that @remixz remove the What do you think about @eXeDK ? |
I think I have some access to the travis-ci setup as well. I'll try and remove the Node4 |
I'll merge this and try and fix the tests afterwards @baudev |
Add the function
sendMessageWithTag(recipient, payload, tag, cb)
which allows sending messages with the specified tag.Example of usage :