Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility of sending message with tag #89

Merged
merged 10 commits into from
Jul 1, 2018
Merged

Add possibility of sending message with tag #89

merged 10 commits into from
Jul 1, 2018

Conversation

baudev
Copy link
Contributor

@baudev baudev commented May 30, 2018

Add the function sendMessageWithTag(recipient, payload, tag, cb) which allows sending messages with the specified tag.

Example of usage :

bot.sendMessageWithTag(payload.sender.id, { "text": "message_test"}, "NON_PROMOTIONAL_SUBSCRIPTION", (error, body) => {
    // ...
});

baudev added 2 commits May 30, 2018 15:17
Add the function `sendMessageWithTag(recipient, payload, tag, cb)` which allows sending messages with the specified tag.
Add the documentation for the function `sendMessageWithTag()`.
@eXeDK
Copy link
Collaborator

eXeDK commented May 30, 2018

Please fix tests @baudev

baudev added 2 commits May 30, 2018 16:10
Fixing continuous integration test failing 'cause of JavaScript Standard Style
Adding missing space making fail the continuous integration test.
@baudev
Copy link
Contributor Author

baudev commented May 30, 2018

Test passed on Node v6 ! https://travis-ci.org/remixz/messenger-bot/jobs/385714367

@eXeDK
Copy link
Collaborator

eXeDK commented May 30, 2018

What about Node4? I have not setup these pipelines so I'm not sure I can make changes to those.
Maybe @remixz can.

@baudev
Copy link
Contributor Author

baudev commented May 30, 2018

The mentioned errors in Node4 don't seem to be related to my MR.

EDIT : Sorry for closing the MR. Mistake on my part.

@baudev baudev closed this May 30, 2018
@baudev baudev reopened this May 30, 2018
Give more flexibility to the `sendMessage()` function by letting the possibility of choosing the `messaging_type` attribute.
Then remove the sendMessageWithTag() function.
Update the documentation for the sendMessage() function. Remove it for sendMessageWithTag() one.
@baudev
Copy link
Contributor Author

baudev commented Jun 8, 2018

The function could be used as following finally :

bot.sendMessage(payload.sender.id, {"text": "message_test"},  (error, body) => {
    // ...
}, 'MESSAGE_TAG', 'NON_PROMOTIONAL_SUBSCRIPTION');

@baudev
Copy link
Contributor Author

baudev commented Jun 20, 2018

This issue's comment istanbuljs/nyc#865 (comment) explains that node 4.x is no more supported with the latest versions of nyc. This is confirmed by the following commit: istanbuljs/nyc@19b7d21

We have two options:

I prefer the last solution: easier and more secure. Then it requires that @remixz remove the node 4 test in his Travis account.

What do you think about @eXeDK ?

@baudev
Copy link
Contributor Author

baudev commented Jun 25, 2018

I tried everything. I think that specifying the tap version doesn't work due to the Travis cache. Anyway.
@remixz should remove the Node4 test or maybe @eXeDK have the rights of editing/remove/add tests ?

@eXeDK
Copy link
Collaborator

eXeDK commented Jul 1, 2018

I think I have some access to the travis-ci setup as well. I'll try and remove the Node4

@eXeDK
Copy link
Collaborator

eXeDK commented Jul 1, 2018

I'll merge this and try and fix the tests afterwards @baudev

@eXeDK eXeDK merged commit 06e0a19 into remixz:master Jul 1, 2018
@baudev baudev deleted the baudev-message-with-tag branch July 3, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants