Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session being lost upon reload/open in new tab #50

Open
FelixGrafschmidt opened this issue Mar 11, 2021 · 4 comments
Open

Session being lost upon reload/open in new tab #50

FelixGrafschmidt opened this issue Mar 11, 2021 · 4 comments

Comments

@FelixGrafschmidt
Copy link

If i reload the page or open a page in a new tab, my session is lost. From what I can tell the session is saved in the vuex store, maybe this could be done server-side to allow users to keep their session over mutliple tabs.

@FelixGrafschmidt
Copy link
Author

Alternatively, if no server is available, this could also be done via localStorage.

yowkah added a commit to yowkah/umi that referenced this issue Dec 11, 2021
Related to remixz#50 . It seems that the Token is not always given with authentication. Absence of the token should not be valid reason to terminate or remove a perfectly good session.
@yowkah
Copy link

yowkah commented Dec 11, 2021

I resolved the issue on my local fork with the above fix. if you could test it as well it would be great

If i reload the page or open a page in a new tab, my session is lost. From what I can tell the session is saved in the vuex store, maybe this could be done server-side to allow users to keep their session over mutliple tabs.

Also, this is a pretty bad idea, Sessions can be used to do all kind of actions on crunchyroll, including giving out the premium-trials etc. I'd rather have that not stored on the server. Umi already uses the localStorage for this, which is perfectly fine. It's just that "refreshing" the page, triggers a logout procedure because of a missing or unset key in the local storage.

@FelixGrafschmidt
Copy link
Author

I can confirm that your fork does fix the issue. I am however not familiar with this project's general structure, therefore I cannot with authority say whether or not this does not lead to any other problems.

@yowkah
Copy link

yowkah commented Dec 12, 2021

In that case we could also change the check to be a check for undefined. since the value gets set to null by the response of the login request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants