Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation: parsing should fail for unknown args #132

Closed
remkop opened this issue May 28, 2017 · 1 comment
Closed

Improve validation: parsing should fail for unknown args #132

remkop opened this issue May 28, 2017 · 1 comment
Labels
type: enhancement ✨ type: question ❔
Milestone
0.9.7

Comments

@remkop
Copy link
Owner

remkop commented May 28, 2017

Currently picocli is lenient: it does not fail or warn if some command line args were "left over", meaning they could not be assigned to any option or positional parameter.

Usually this should be treated as an error. "Strict" parsing mode should be the default.

If it is not difficult to preserve the current behaviour it can be made configurable through a CommandLine.setLenient(boolean) method or potentially through a system property to allow end users to tweak this for their particular use case.
@remkop remkop added this to the backlog milestone May 28, 2017
@remkop remkop mentioned this issue May 28, 2017
Closed
@pditommaso
Copy link
Contributor

I agree on strict as default throwing and exception when an unrecognised option is entered and a CommandLine.setLenient(boolean) to disable it.

@remkop remkop modified the milestones: 0.9.7, backlog May 28, 2017
@remkop remkop changed the title Parsing should fail if args were left over Improve validation: parsing should fail for unknown args May 31, 2017
remkop added a commit that referenced this issue Jun 3, 2017
@remkop
#132 Improve validation: parsing should fail for unknown args
78f575a 
(initial implementation)
@remkop remkop closed this as completed in 07d5718 Jun 3, 2017
remkop added a commit that referenced this issue Jun 4, 2017
@remkop
#132 added RELEASE-NOTES entry for #132 Improve validation: parsing s…
802c70c 
…hould fail for unknown args
@remkop remkop mentioned this issue Jun 4, 2017
Closed
remkop added a commit that referenced this issue Jun 4, 2017
@remkop
#132 renamed UnknownArgumentException to UnmatchedArgumentException
b4fb1ba
remkop added a commit that referenced this issue Jun 4, 2017
@remkop
#132 update tests for new error message
de51e9f
remkop added a commit that referenced this issue Aug 26, 2017
@remkop
#132 unmatched arguments javadoc improvement
24f224c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement ✨ type: question ❔
Projects
None yet
Milestone
0.9.7
Development

No branches or pull requests
2 participants
@pditommaso @remkop