Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online execution of sample apps: improvements (#1196) #1199

Closed
wants to merge 1 commit into from
Closed

Online execution of sample apps: improvements (#1196) #1199

wants to merge 1 commit into from

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 2, 2020

Changes as requested here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020

Codecov Report

Merging #1199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1199   +/-   ##
=========================================
  Coverage     94.30%   94.30%           
  Complexity      455      455           
=========================================
  Files             2        2           
  Lines          6674     6674           
  Branches       1794     1794           
=========================================
  Hits           6294     6294           
  Misses          102      102           
  Partials        278      278           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d05e6...097833d. Read the comment docs.

@remkop remkop closed this in 262d5a2 Oct 3, 2020
@remkop
Copy link
Owner

remkop commented Oct 3, 2020

Looks like I made some changes that caused conflicts, so I added your proposed changes manually.
Thanks, I had forgotten about the Kotlin and Scala examples!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants