-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick guide: online execution of sample apps #1196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
============================================
+ Coverage 94.26% 94.30% +0.04%
Complexity 455 455
============================================
Files 2 2
Lines 6674 6674
Branches 1793 1794 +1
============================================
+ Hits 6291 6294 +3
+ Misses 105 102 -3
Partials 278 278
Continue to review full report at Codecov.
|
Thanks for the PR. |
Thank you very much! I changed the titles a bit: instead of having to sections called "Online execution", there is now one section "ASCIIArt execution" and one section "ISOCodeResolver execution", similar for "Source code explained". I also added a brief note above the embedded JDoodle.com section, in case something goes wrong, with a link that people can use to display the example in a separate browser tab. TOC depth: I changed it back to only one level. I think this is less intimidating. The user manual has a very long TOC that allows more precise navigation, but also emphasizes that the document has a lot of detail. I thought it made sense to try to stay high-level in the Quick Guide. I made Basic Example and Subcommand Example top-level sections in Quick Guide so they show up separately in the TOC. The
The reason is that picocli automatically adds an ellipsis |
Great work I appreciate it!
Yes. JDoodle examples are updated already. I will correct the samples in the .adoc and example section soon. I willing to author another pull request adding JDoodle online execution for the checksum example in the user manual. |
Yes, that would be great! FYI |
I pushed the rendered HTML. I thought it would be better to change the order and have the explanation first, and then allow people to play with execution. One minor detail, the paramLabel = "language code>", --> missing `<` opening fish bracket |
You are welcome.
I see the point. Looks good to me.
This is fixed now. |
Thank you for the quick fix! |
This PR, ready for merging, supersedes #1188.
This is my attempt to add online execution to the quick guide.
Please let me know how you like it.