Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User manual: online execution of checksum sample app #1200

Merged
merged 1 commit into from
Oct 3, 2020
Merged

User manual: online execution of checksum sample app #1200

merged 1 commit into from
Oct 3, 2020

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 2, 2020

See discussion here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020

Codecov Report

Merging #1200 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1200   +/-   ##
=========================================
  Coverage     94.30%   94.30%           
  Complexity      455      455           
=========================================
  Files             2        2           
  Lines          6674     6676    +2     
  Branches       1794     1795    +1     
=========================================
+ Hits           6294     6296    +2     
  Misses          102      102           
  Partials        278      278           
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 94.14% <0.00%> (+<0.01%) 314.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d05e6...47444d6. Read the comment docs.

Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I am very picky about especially the beginning of the user manual.
Please don't take this as criticism, but as positive feedback!

docs/index.adoc Outdated Show resolved Hide resolved
docs/index.adoc Outdated Show resolved Hide resolved
docs/index.adoc Show resolved Hide resolved
docs/index.adoc Outdated Show resolved Hide resolved
@deining
Copy link
Contributor Author

deining commented Oct 3, 2020

Sorry, I am very picky about especially the beginning of the user manual.
Please don't take this as criticism, but as positive feedback!

I like the way we interact and cooperate on this project.
Don't merge anything that you are not convinced of.
In the past, your comments always lead to an inprovement in some or the other way, let's go ahead with this!

@deining deining requested a review from remkop October 3, 2020 10:15
@remkop remkop merged commit 0520698 into remkop:master Oct 3, 2020
remkop added a commit that referenced this pull request Oct 3, 2020
@remkop
Copy link
Owner

remkop commented Oct 3, 2020

Merged. Thanks a lot, this is pretty cool!
I made the text as terse as possible, I hope you like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants