Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed isJansiConsoleInstalled performance issue #1976

Merged
merged 8 commits into from
Mar 24, 2023
Merged

Fixed isJansiConsoleInstalled performance issue #1976

merged 8 commits into from
Mar 24, 2023

Commits on Mar 19, 2023

  1. Fixed isJansiConsoleInstalled performance issue 

    isJansiConsoleInstalled() was repeatedly called
in a loop from the TextTable#toString method,
which caused performance problems due to the
constant calls to Class#forName.  This change
caches the result from isJansiConsoleInstalled so
it doesn't repeatedly call Class#forName, which
cannot change at runtime.
    @ChrisTrenkamp
    ChrisTrenkamp committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    89e0382 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Fixed failing test for Ansi.enabled() 

    Fixed unit test by resetting the cached isJansiConsoleInstalled result.
    @ChrisTrenkamp
    ChrisTrenkamp committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2400268 View commit details
    Browse the repository at this point in the history

  2. Fixed unexpected Ansi result in 

    ModelTransformerTest#testUsage
    @ChrisTrenkamp
    ChrisTrenkamp committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    a28578e View commit details
    Browse the repository at this point in the history

  3. Fixed comment.

    @ChrisTrenkamp
    ChrisTrenkamp committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    a8edda3 View commit details
    Browse the repository at this point in the history

  4. Fixed the rest of the failing test cases.

    @ChrisTrenkamp
    ChrisTrenkamp committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7ed559c View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Merge branch 'main' into jansi-console-cache

    @remkop
    remkop committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    446d79b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jansi-console-cache

    @remkop
    remkop committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    842f517 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into jansi-console-cache

    @remkop
    remkop committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    c4ed052 View commit details
    Browse the repository at this point in the history