Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the currently checked-out branch as the baseBranch #17

Closed
wants to merge 2 commits into from
Closed

Conversation

paketb0te
Copy link

instead of using the default "master" or the environment variable MOB_BASE_BRANCH, we get the currently checked-out branch from git and set it as the baseBranch.

Solves #14

Manuel Stausberg and others added 2 commits March 14, 2020 18:18
use the currently checked-out branch as baseBranch
@paketb0te paketb0te closed this Mar 14, 2020
@koppor
Copy link

koppor commented May 24, 2020

@MStausberg Could you state why this PR was closed? I think, it's a good solution. Maybe the user prompt could be added:

The branch "feature-123" is used as mob-base branch. Do you want to continue?

@paketb0te
Copy link
Author

Yeah I realized I made a logical error, the solution I implemented would set the base branch to the current branch whenever any mob-command is executed.
So it would work fine when starting, but afterwards it would change the base branch to the mob-branch.

@simonharrer
Copy link
Member

I'm working on v1.0.0 right now in #38 and it may help in providing a solution to a more flexible "start" branch and a "done" branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants