New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mob start with ci skip option #354
mob start with ci skip option #354
Conversation
bfb522a
to
2715740
Compare
df3bc70
to
8c4223f
Compare
aa504d2
to
66f86a0
Compare
66f86a0
to
9a1f8cb
Compare
9a1f8cb
to
f0300b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, well done.
I think we can omit the configuration code all together, as we always want to skip the CI.
We made the same decision when we implemented the push options.
Then the change becomes much smaller.
Less code = better, less maintenance.
@@ -14,6 +14,8 @@ const ( | |||
Squash = "squash" | |||
NoSquash = "no-squash" | |||
SquashWip = "squash-wip" | |||
|
|||
StartCISkipCommitMessage = "mob start [ci-skip] [ci skip] [skip ci]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels weird that this constant is in the same place as the other 3 that share a concept. But I don't know how to solve that better now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To define it as variable instead of constant is one of the options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, introduce new type, something like SquashOption
, to clarify the difference:
type SquashOption string
const (
Squash = SquashOption("squash")
NoSquash = SquashOption("no-squash")
SquashWip = SquashOption("squash-wip")
StartCISkipCommitMessage = "mob start [ci-skip] [ci skip] [skip ci]"
)
LGTM, can you please increase the version number to Line 29 in 4ac1d3e
and add a changelog entry describing what we did? I think then we can merge. |
I did, please fix the changelog message if necessary. Thanks for discussing and reviewing, @gregorriegler! I am so excited for my PR to be released. |
Summary
Implement CI skipping function when
mob start
.Check out #353 for details.
Implementation (editted)
mob start
mob start [ci-skip] [ci skip] [skip ci]
.--push-option ci.skip
mob done --squash-wip
markStartCommitForDropping()
.mob done
ormob done --squash
.mob done --no-squash
.