fix: support maximum 0 in number field

src/tests/createHeadlessForm.test.js

@@ -16,6 +16,7 @@ import {
   schemaInputTypeSelectMultiple,
   schemaInputTypeSelectMultipleOptional,
   schemaInputTypeNumber,
+  schemaInputTypeNumberZeroMaximum,
   schemaInputTypeDate,
   schemaInputTypeEmail,
   schemaInputWithStatement,
@@ -780,6 +781,29 @@ describe('createHeadlessForm', () => {
       expect(() => fieldValidator.validateSync('')).toThrowError('The value must be a number');
     });
 
+    it('shows an error when positive number is entered into a "number" field with maximum set to zero', () => {
+      const result = createHeadlessForm(schemaInputTypeNumberZeroMaximum);
+      expect(result).toMatchObject({
+        fields: [
+          {
+            description: 'How many open tabs do you have?',
+            label: 'Tabs',
+            name: 'tabs',
+            required: false,
+            schema: expect.any(Object),
+            type: 'number',
+            minimum: -100,
+            maximum: 0,
+          },
+        ],
+      });
+      const fieldValidator = result.fields[0].schema;
+      expect(fieldValidator.isValidSync('0')).toBe(true);
+      expect(fieldValidator.isValidSync('10')).toBe(false);
+      expect(fieldValidator.isValidSync('-11')).toBe(true);
+      expect(() => fieldValidator.validateSync('5')).toThrowError('Must be smaller or equal to 0');
+    });
+
     it('support "number" field type with the percentage attribute', () => {
       const result = createHeadlessForm(schemaInputTypeNumberWithPercentage);
       expect(result).toMatchObject({

src/tests/helpers.js

@@ -46,6 +46,23 @@ export const mockNumberInput = {
   type: 'number',
 };
 
+export const mockNumberInputNegative = {
+  title: 'Tabs',
+  description: 'How many open tabs do you have?',
+  'x-jsf-presentation': {
+    inputType: 'number',
+  },
+  minimum: -100,
+  maximum: 0,
+  type: 'number',
+};
+
+export const schemaInputTypeNumberZeroMaximum = JSONSchemaBuilder()
+  .addInput({
+    tabs: mockNumberInputNegative,
+  })
+  .build();
+
 export const mockNumberInputWithPercentage = {
   title: 'Shares',
   description: 'What % of shares do you own?',

src/yupSchema.js

@@ -240,7 +240,8 @@ export function buildYupSchema(field, config) {
     validators.push(withMinLength);
   }
 
-  if (propertyFields.maximum) {
+  // support maximum with 0 value
+  if (propertyFields.maximum !== undefined) {
     validators.push(withMax);
   }