Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox: Retrieves & uses refresh token to obtain new access token #1274

Merged
merged 11 commits into from
Oct 27, 2022
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-and-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Run jaribu tests # These must be replaced before we can use Node v18 in CI
run: npm test
- name: Run mocha tests
run: npm run test:mocha
run: npm run test:mocha -- --exit
- name: Run linter
run: npm run lint:quiet
- name: Run webpack
Expand Down
5 changes: 5 additions & 0 deletions doc/contributing/internals/discovery-bootstrap.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,9 @@ the user to that URL. When the dance comes back, the library will detect
the ``access_token`` from the window location during the page load, and
from that point onwards, the remote is connected.

If the OAuth flow is PKCE, the window location will contain a ``code``
parameter instead of ``access_token``. RS then makes a fetch to
remote.TOKEN_URL with the code, to retrieve the access token, and possibly
a refresh token as well.

.. _storage-first section: https://tools.ietf.org/html/draft-dejong-remotestorage-09#section-11
11 changes: 8 additions & 3 deletions doc/getting-started/dropbox-and-google-drive.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,15 @@ Dropbox
An app key can be obtained by `registering your app
<https://www.dropbox.com/developers/apps>`_.

* Create a new app for the "Dropbox API", with "Full Dropbox access"
* Create a new "scoped" app for the "Dropbox API", with these scopes:
* account_info.read
* files.metadata.read
* files.metadata.write
* files.content.read
* files.content.write
* You need to set one or more OAuth2 redirect URIs for all routes a user can
connect from, for example ``http://localhost:8000/`` for an app you are
developing locally.
connect from, for example ``http://localhost:8000`` for an app you are
developing locally. If the path is '/', remoteStorage drops it.
DougReeder marked this conversation as resolved.
Show resolved Hide resolved

Known issues
^^^^^^^^^^^^
Expand Down