Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was done together with @calvin-f and @j0nezz with the goal of improving the test code quality of the core package.
A few notes on two things we changed:
isValidLogLevel
insidelog.ts
. Currently, the not listed log levels would be recognized as valid, even tho they should be recognized as invalid.get-media-time.ts
was missing the.test
in the file name, so the tests were not running. We renamed it toget-current-time.test.ts
and improved the tests so they would pass.So we hope this PR helps, if you have some comments / change requests let us know :)