Minor test suite improvements #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot again! 🙌 Indeed, there was a bug, thanks a lot for spotting and fixing it, alongside the various tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was done together with @calvin-f and @j0nezz with the goal of improving the test code quality of the core package.
A few notes on two things we changed:
isValidLogLevelinsidelog.ts. Currently, the not listed log levels would be recognized as valid, even tho they should be recognized as invalid.get-media-time.tswas missing the.testin the file name, so the tests were not running. We renamed it toget-current-time.test.tsand improved the tests so they would pass.So we hope this PR helps, if you have some comments / change requests let us know :)