Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Templates✅ #484

Merged
merged 4 commits into from Jul 2, 2021

Conversation

sohamsshah
Copy link
Contributor

@sohamsshah sohamsshah commented Jun 29, 2021

Have added Github Issue Templates and updated the existing Pull Request Template that fixes #483

Let me know if any changes are required.

Thanks

@JonnyBurger
Copy link
Member

Thanks! I think this is a step in the right direction to improve the issue handling.

However, I think it's a bit too strict even, I enjoy the fact that on Remotion you don't have to fill out a long template with stuff like Expected behavior / actual behavior etc. Fortunately so far people have been able to open issues that clearly elaborate the matter.

So I would like to partially merge it, and loosen up the templates a bit. I'll think about it and return to this issue. What do other people think of it?

@sohamsshah
Copy link
Contributor Author

sohamsshah commented Jun 29, 2021

Thanks! I think this is a step in the right direction to improve the issue handling.

However, I think it's a bit too strict even, I enjoy the fact that on Remotion you don't have to fill out a long template with stuff like Expected behavior / actual behavior etc. Fortunately so far people have been able to open issues that clearly elaborate the matter.

So I would like to partially merge it, and loosen up the templates a bit. I'll think about it and return to this issue. What do other people think of it?

Let me know what addition/subtraction I can do upon this?
Also as an alternative, we can have yml files for issue templates just like how next does

In my opinion, the above approach is also must pondering upon.

Thanks!

@Iamshankhadeep
Copy link
Contributor

However, I think it's a bit too strict even, I enjoy the fact that on Remotion you don't have to fill out a long template with stuff like Expected behavior / actual behavior etc. Fortunately so far people have been able to open issues that clearly elaborate the matter.

So I would like to partially merge it, and loosen up the templates a bit. I'll think about it and return to this issue. What do other people think of it?

LGTM but I also think we should loosen up it more. Btw thanks for this @sohamsshah

@JonnyBurger
Copy link
Member

I slimmed it down as much as possible so we can work faster, but there were a lot of good points of practices that the authors should do! I made sure to mention all of those.

Thanks a lot for tackling those 💫

@JonnyBurger JonnyBurger merged commit 07f2076 into remotion-dev:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Github Templates to the repository
3 participants