Float: Introduce floating point api infinite #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the TODO workaround as fixed. Signed-off-by: Pan Li <pan2.li@intel.com>
* Introduce new float api float_is_inf. * Add test case for half, single and double floating point. * Add inf to interface. Signed-off-by: Pan Li <pan2.li@intel.com>
…oat-point-infinite
13 tasks
Signed-off-by: Pan Li <pan2.li@intel.com>
jordancarlin
reviewed
May 7, 2024
lib/float/inf.sail
Outdated
| val float_is_inf : fp_bits -> bool | ||
| function float_is_inf (op) = { | ||
| let struct {_, exp, mantissa} = float_decompose(op); | ||
| let is_nan = exp == sail_ones(length(exp)) |
There was a problem hiding this comment.
Should probably be is_inf instead of is_nan
There was a problem hiding this comment.
Nice catch, thanks and updated!
Signed-off-by: Pan Li <pan2.li@intel.com>
Alasdair
reviewed
May 8, 2024
test/float/inf_test.sail
Outdated
| $include <float/inf.sail> | ||
|
|
||
| function test_float_is_inf() -> unit = { | ||
| /* Half flating point */ |
There was a problem hiding this comment.
Typo in the comments here
There was a problem hiding this comment.
Oops, let me update soon and file another PR for other test files.
Signed-off-by: Pan Li <pan2.li@intel.com>
|
Sorry for taking a while with these, I've been rather busy the past week. |
Thanks. Never mind and take your time, ;)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pan Li pan2.li@intel.com