-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application Error #1451
Comments
Looks like it's crashing quite often:
|
@Richienb didn't you do a refactor recently? |
@remy I did one three months ago. |
This issue only happens periodically - I am unable to reproduce it consistently. |
I (think I) found the problem: It's all to do with a Javascript quirk. Here we assign mit-license/middleware/load-user.js Lines 17 to 20 in aa280a6
Notice that we await it within the assignment. What do you think It actually temporarily sets it to what is essentially To fix it, we just need to await the data before the assignment: mit-license/middleware/load-user.js Lines 17 to 22 in 6d916f4
I've just set up a quick uptime page so we can track if this change did anything. |
At a guess, the get router is getting the user object as undefined (via an
incorrect cname lookup) and has been crashing regularly. Maybe an object
test before that (or similar) lines.
…On Mon, 14 Dec 2020, 16:31 Richie Bendall, ***@***.***> wrote:
This issue only happens periodically - I am unable to reproduce it
consistently.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1451 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADLBFGBQGJUDHNBOBY56LSUY4UNANCNFSM4U2UMBSQ>
.
|
cname lookup? |
Sorry, we're crossing messages. That await won't return the user object until the promise has settled (so the refactor here shouldn't make any difference). The user object is definitely undefined. If it were set to a promise it would pass the test for |
It seems to be working again now. |
Yes, but it'll crash again. There's a bug that causes it to trip and crash.
…On Mon, 14 Dec 2020, 17:04 Tim Long, ***@***.***> wrote:
It seems to be working again now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1451 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADLBBB7S6H6L3TOCNLXBTSUZARTANCNFSM4U2UMBSQ>
.
|
The last recorded downtime is on February 11, 2021. I believe this means the issue is now resolved. |
Oops, it looks like there's a server issue...
The text was updated successfully, but these errors were encountered: